Correct a couple of typos in hor_visc#4
Conversation
1. Three typos are corrected. 2. An if-statement for better bound of the Laplacian viscosity at h-cell is moved outside of the do-loops.
|
PS: I am actually not sure if I should be submitting to this repo or the mom-ocean one (dev/gfdl branch there??). Let me know if I should redo this (or wait until the transition is finalized). Thanks! |
|
@herrwang0 Let's handle this at NOAA-GFDL for now. We'll talk about how to handle PRs to mom-ocean at the next meetup. |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #4 +/- ##
=========================================
Coverage 29.15% 29.15%
=========================================
Files 239 239
Lines 71463 71463
=========================================
Hits 20833 20833
Misses 50630 50630
Continue to review full report at Codecov.
|
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree with these corrections. Thank you for spotting and correcting them @herrwang0.
This has passed TC testing, and it passed the MOM6 regression testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14120.
In your case, @herrwang0, NOAA-gfdl:dev/gfdl is the appropriate primary development fork, although for other people another one (like NCAR:dev/ncar or NOAA-emc:dev/emc) might be more appropriate.
I will be updating MOM6-examples to reflect the altered MOM_parameter_doc files resulting from this PR.
3 participants
is moved outside of the do-loops.